Backport #19004 to release/1.5.x #19130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] Honor job's namespace when checking `distinct_hosts` feasibility * Update distinct_host feasibility checking to honor the job's namespace. Fixes #9792 * Added test to verify original condition and that fix resolved it. * Added documentation Manual backport due to merge conflicts in upgrade-specific.mdx
lgfa29
approved these changes
Nov 20, 2023
Comment on lines
+31
to
+32
| [tasks within a group are scheduled on the same client node][group]. | ||
| </Warning> |
There was a problem hiding this comment.
Suggested change
| [tasks within a group are scheduled on the same client node][group]. | |
| </Warning> | |
| [tasks within a group are scheduled on the same client node][group]. | |
| </Warning> |
I'm not sure if it matters, so feel free to ignore this, but I usually see these block surrounded by line breaks.
There was a problem hiding this comment.
It's only required to stand off the opening tag when there's markdown inside the component. The closing one doesn't need a standoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] Honor job's namespace when checking
distinct_hostsfeasibilityManual backport because of conflicts in upgrade-specific.mdx