Backport of E2E: fix assertion in dynamic node metadata test into release/1.5.x #19122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/e2e-node-meta-dynamic-assertion/solely-valued-haddock
branch
from
02ce3bf to
50fc0df
Compare
hc-github-team-nomad-core
force-pushed
the
backport/e2e-node-meta-dynamic-assertion/solely-valued-haddock
branch
from
dea47d5 to
1b038bd
Compare
tgross
approved these changes
Nov 17, 2023
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
tgross
deleted the
backport/e2e-node-meta-dynamic-assertion/solely-valued-haddock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19120 to be assessed for backporting due to the inclusion of the label backport/1.5.x.
The below text is copied from the body of the original PR.
In #18664 we change how null values worked with dynamic node metadata so that they were no longer returned if there wasn't also a static value for that key. The test assertion in E2E was not updated to match the new behavior.
Fixes: #19112
Overview of commits