18529 nomad executes any file in plugins #18530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch does not have a config specified.
… extensions are not executed.
|
Hi @stswidwinski 👋 Just to circle back to this after #18529 (comment), I've opened #19189 to start the deprecation process of this behaviour in Nomad 1.7, and then we can turn the warning to an error as you have it here in Nomad 1.8. We'll probably need to fix the merge conflict after #19189 is merged, but we can get there once we're ready to merge this one. Thanks for the PR! |
|
Thank you for following up! Please let me know when we're ready to work on merging this in and I'll be happy to follow up |
tgross
added
the
stage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #18529