Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Search results are overloading filter with sorted results into release/1.6.x #18105

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18053 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


Bit of context here:

image image

This PR attempts to both preserve the ability to sort after searching, and not overload results with searched-but-not-ordered filter results by creating a new getter() that checks to see if any sorting has been applied.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/18030-ui-search-results-are-overloading-filter-with-sorted-results/actively-holy-tortoise branch from 630a55d to 93ca81a Compare July 31, 2023 17:07
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 1acc701 into release/1.6.x Jul 31, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/18030-ui-search-results-are-overloading-filter-with-sorted-results/actively-holy-tortoise branch July 31, 2023 17:07
@github-actions
Copy link

Ember Test Audit comparison

release/1.6.x 481d684 change
passes 1498 1499 +1
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants