Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] When a purged/404-ing job is detected, boot the user out of that job and back to the index into release/1.6.x #18009

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #17915 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


  • In the event that a job is removed/purged/GC'd from elsewhere while the user is actively on a job page, this PR causes an event to fire that 1. boots the user back to the jobs index page, and 2. gives them a sticky notification about what happened.
  • Moves the "job watcher" from jobs.job.index level to jobs.job level, so a "yoinked" job can be observed from anyplace within the job's subnav, not just the index page
  • extends the watchRecord watcher util to accept a shouldSurfaceErrors param. This is experimental, but makes it so that elsewhere we can check this.model.watchers.{}.isError, where before it was being yielded but not set on the watcher itself.
image

Resolves #17757

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/17757-restartreschedule-links-on-job-index-page-arent-cleared-after-job-deletion/frankly-outgoing-drake branch from f2596b8 to e70d6bb Compare July 20, 2023 16:37
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 1c903e2 into release/1.6.x Jul 20, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/17757-restartreschedule-links-on-job-index-page-arent-cleared-after-job-deletion/frankly-outgoing-drake branch from a71bcfc to 01ce5ef Compare July 20, 2023 16:37
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/17757-restartreschedule-links-on-job-index-page-arent-cleared-after-job-deletion/frankly-outgoing-drake branch July 20, 2023 16:37
@github-actions
Copy link

Ember Test Audit comparison

release/1.6.x 01ce5ef change
passes 1496 1498 +2
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants