Backport of replication: fix potential panic during upgrades into release/1.5.x #17493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/auth-object-replication-panic/uniquely-firm-wren
branch
from
a2ae5fa to
c539c31
Compare
hc-github-team-nomad-core
force-pushed
the
backport/auth-object-replication-panic/uniquely-firm-wren
branch
from
0db16db to
42fa898
Compare
hc-github-team-nomad-core
deleted the
backport/auth-object-replication-panic/uniquely-firm-wren
branch
tgross
pushed a commit
that referenced
this pull request
Jun 12, 2023
…ease/1.5.x (#17493) This pull request was automerged via backport-assistant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17476 to be assessed for backporting due to the inclusion of the label backport/1.5.x.
The below text is copied from the body of the original PR.
If the authoritative region has been upgraded to a version of Nomad that has new replicated objects (such as ACL Auth Methods, ACL Binding Rules, etc.), the non-authoritative regions will start replicating those objects as soon as their leader is upgraded. If a server in the non-authoritative region is upgraded and then becomes the leader before all the other servers in the region have been upgraded, then it will attempt to write a Raft log entry that the followers don't understand. The followers will then panic.
Add same the minimum version checks that we do for RPC writes to the leader's replication loop.
This will need to be backported to 1.5.x but hand-picked over to 1.4.x because some of these changes are only in 1.5.x