fix: job canonicalization should set job priority to 50, not 0. #17314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
added
backport/1.3.x
|
I see the problem in nomad/command/agent/job_endpoint_test.go Line 380 in 2aa3c74 |
tgross
requested changes
May 25, 2023
There was a problem hiding this comment.
@pkazmierczak this looks right at first in terms of the canonicalization but in the Job.Register RPC we set the priority to the default priority (50) if the priority is 0. So this would break that and make it so that jobs with unset priority are set to 1 instead of 50.
ref https://github.com/hashicorp/nomad/blob/v1.5.5/nomad/job_endpoint.go#L866-L869
pkazmierczak
changed the title
shoenig
approved these changes
May 25, 2023
api/jobs.go
Outdated
| @@ -1003,7 +1003,7 @@ func (j *Job) Canonicalize() { | |||
| j.Namespace = pointerOf(DefaultNamespace) | |||
| } | |||
| if j.Priority == nil { | |||
| j.Priority = pointerOf(0) | |||
| j.Priority = pointerOf(1) | |||
There was a problem hiding this comment.
I think we claim the default is 50 - should that be the value set here?
https://developer.hashicorp.com/nomad/docs/job-specification/job#priority
edit: dangit, forgot to hit submit
This was referenced May 30, 2023
pkazmierczak
added a commit
that referenced
this pull request
May 30, 2023
Nomad API will reject jobs with priority set to 0.
pkazmierczak
added a commit
that referenced
this pull request
May 30, 2023
Nomad API will reject jobs with priority set to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad API will reject jobs with priority set to 0.