Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Fixed: Evaluations sidebar/response not scrollable into release/1.5.x #16999

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Backport of [ui] Fixed: Evaluations sidebar/response not scrollable into release/1.5.x #16999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d64a10
backport of commit 9255d70d37a247dc38f70c2963b4b394ef278c10
philrenaud Apr 21, 2023
9013453
backport of commit 5e2acbde44123e2cf23ada93c7193eccd3cb814e
philrenaud Apr 21, 2023
f624fbb
backport of commit 5f1f452e493f45fefbd6bf22555782cf063ded3c
philrenaud Apr 21, 2023
e2df903
backport of commit bb9927d75ff9f0024a39ebff11c4b3f80de584ff
philrenaud Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/16960.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fix a visual bug where evaluation response wasn't scrollable in the Web UI.
```
4 changes: 2 additions & 2 deletions ui/app/components/evaluation-sidebar/detail.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div
data-test-eval-detail
data-test-eval-detail-is-open={{this.isSideBarOpen}}
class="sidebar {{if this.isSideBarOpen "open"}}"
class="sidebar {{if this.isSideBarOpen "open"}} evaluations-sidebar"
{{on-click-outside
this.closeSidebar
capture=true
Expand Down Expand Up @@ -157,7 +157,7 @@
</div>
{{/if}}
{{! Evaluation JSON Response}}
<div class="boxed-section">
<div class="boxed-section evaluation-response">
<div class="boxed-section-head">
Evaluation Response
</div>
Expand Down
20 changes: 20 additions & 0 deletions ui/app/styles/components/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,26 @@ $subNavOffset: 49px;
box-shadow: -5px 0 10px -5px rgb(0 0 0 / 20%);
border-radius: 16px;
}

&.evaluations-sidebar {
display: flex;
gap: 1.5rem;
flex-direction: column;

& > .evaluation-response {
display: grid;
min-height: 200px;
grid-template-rows: auto 1fr;
overflow: hidden;
& > .boxed-section-body {
overflow: auto;
}
}
& > div,
h1.title {
margin: 0;
}
}
}

.sidebar-content {
Expand Down