Backport of nsd: always set deregister flag after deregistration of group into release/1.4.x #16537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/nsd-fix-dregister-lock/deadly-adequate-mako
branch
from
bd54279 to
ec75ab3
Compare
hc-github-team-nomad-core
force-pushed
the
backport/nsd-fix-dregister-lock/deadly-adequate-mako
branch
from
ec75ab3 to
bd54279
Compare
|
|
(manual cherry-pick of ed498f8) * services: always set deregister flag after deregistration of group This PR fixes a bug where the group service hook's deregister flag was not set in some cases, causing the hook to attempt deregistrations twice during job updates (alloc replacement). In the tests ... we used to assert on the wrong behvior (remove twice) which has now been corrected to assert we remove only once. This bug was "silent" in the Consul provider world because the error logs for double deregistration only show up in Consul logs; with the Nomad provider the error logs are in the Nomad agent logs. * services: cleanup group service hook tests
shoenig
force-pushed
the
backport/nsd-fix-dregister-lock/deadly-adequate-mako
branch
from
ec3e63e to
f15d293
Compare
shoenig
deleted the
backport/nsd-fix-dregister-lock/deadly-adequate-mako
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16289 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR fixes a bug where the group service hook's deregister flag was not set in
Postrun(), causing the hook to attempt deregistrations twice during job updates (alloc replacement), wherePreKill()would also do a deregistration. With the Nomad service provider, this shows up as Error logs on every job update.First commit is the bug fix, second is drive by test cleanup.