Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update ioutil deprecated library references to os and io respectively in the client package #16318

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

lhaig
Copy link
Contributor

@lhaig lhaig commented Mar 3, 2023

No user facing changes so I assume no change log is required.

@lhaig lhaig marked this pull request as ready for review March 4, 2023 06:37
@lhaig lhaig changed the title Update ioutil deprecated library references to os and io respectively in the client package deps: Update ioutil deprecated library references to os and io respectively in the client package Mar 4, 2023
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhaig - just the one fix needed in 2 places, where we shouldn't ignore an error.

client/allocdir/task_dir.go Outdated Show resolved Hide resolved
client/allocdir/alloc_dir.go Outdated Show resolved Hide resolved
Add error handling to filEntry info
Add error handling to info
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shoenig shoenig added backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line labels Mar 8, 2023
@shoenig shoenig merged commit 48e7d70 into main Mar 8, 2023
@shoenig shoenig deleted the f-ioutil-deprecation-client branch March 8, 2023 19:25
shoenig pushed a commit that referenced this pull request Mar 8, 2023
…tively in the client package (#16318)

(manual cherry-pick of 48e7d70)

* Update ioutil deprecated library references to os and io respectively

* Deal with the errors produced.

Add error handling to filEntry info
Add error handling to info
shoenig pushed a commit that referenced this pull request Mar 8, 2023
…tively in the client package (#16318) (#16397)

(manual cherry-pick of 48e7d70)

* Update ioutil deprecated library references to os and io respectively

* Deal with the errors produced.

Add error handling to filEntry info
Add error handling to info

Co-authored-by: Lance Haig <[email protected]>
shoenig pushed a commit that referenced this pull request Mar 8, 2023
…tively in the client package (#16318)

(manual cherry-pick of 48e7d70)

* Update ioutil deprecated library references to os and io respectively

* Deal with the errors produced.

Add error handling to filEntry info
Add error handling to info
shoenig pushed a commit that referenced this pull request Mar 8, 2023
…tively in the client package (#16318) (#16396)

(manual cherry-pick of 48e7d70)

* Update ioutil deprecated library references to os and io respectively

* Deal with the errors produced.

Add error handling to filEntry info
Add error handling to info

Co-authored-by: Lance Haig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants