-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update ioutil deprecated library references to os and io respectively in the client package #16318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhaig
changed the title
Update ioutil deprecated library references to os and io respectively in the client package
deps: Update ioutil deprecated library references to os and io respectively in the client package
Mar 4, 2023
shoenig
suggested changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lhaig - just the one fix needed in 2 places, where we shouldn't ignore an error.
Add error handling to filEntry info Add error handling to info
shoenig
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shoenig
added
backport/1.3.x
backport to 1.3.x release line
backport/1.4.x
backport to 1.4.x release line
backport/1.5.x
backport to 1.5.x release line
labels
Mar 8, 2023
This was referenced Mar 8, 2023
shoenig
pushed a commit
that referenced
this pull request
Mar 8, 2023
…tively in the client package (#16318) (#16397) (manual cherry-pick of 48e7d70) * Update ioutil deprecated library references to os and io respectively * Deal with the errors produced. Add error handling to filEntry info Add error handling to info Co-authored-by: Lance Haig <[email protected]>
shoenig
pushed a commit
that referenced
this pull request
Mar 8, 2023
…tively in the client package (#16318) (#16396) (manual cherry-pick of 48e7d70) * Update ioutil deprecated library references to os and io respectively * Deal with the errors produced. Add error handling to filEntry info Add error handling to info Co-authored-by: Lance Haig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.3.x
backport to 1.3.x release line
backport/1.4.x
backport to 1.4.x release line
backport/1.5.x
backport to 1.5.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No user facing changes so I assume no change log is required.