artifact: protect against unbounded artifact decompression (1.2.x) (#… #16158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16126) * artifact: protect against unbounded artifact decompression This PR enables mitigations provided by go-getter against payloads which decompress into an unbounded size or file count. There are two new client config options under the artifact block: artifact.decompression_size_limit (e.g. "10GB") - the maximum amount of data that will be decompressed before triggering an error and cancelling the operation artifact.decompression_file_count_limit (e.g. 1024) - the maximum number of files that will be decompressed before triggering ana error and cancelling the operation. * fixup CR comments * deps: update to go-getter 1.7.0
shoenig
force-pushed
the
artifact-limits-backport-1.2.x
branch
from
bd6fa53 to
4f78627
Compare
lgfa29
approved these changes
Feb 13, 2023
tgross
pushed a commit
that referenced
this pull request
Feb 14, 2023
…16126) (#16158) * artifact: protect against unbounded artifact decompression This PR enables mitigations provided by go-getter against payloads which decompress into an unbounded size or file count. There are two new client config options under the artifact block: artifact.decompression_size_limit (e.g. "10GB") - the maximum amount of data that will be decompressed before triggering an error and cancelling the operation artifact.decompression_file_count_limit (e.g. 1024) - the maximum number of files that will be decompressed before triggering ana error and cancelling the operation. * fixup CR comments * deps: update to go-getter 1.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16126 (because BPA doesn't work on non-main branches)
…16126)
This PR enables mitigations provided by go-getter against payloads which decompress into an unbounded size or file count.
There are two new client config options under the artifact block:
artifact.decompression_size_limit (e.g. "10GB") - the maximum amount of data that will be decompressed before triggering an error and cancelling the operation
artifact.decompression_file_count_limit (e.g. 1024) - the maximum number of files that will be decompressed before triggering ana error and cancelling the operation.
fixup CR comments
deps: update to go-getter 1.7.0