agent: fix agent HTTP server audit event implementation access. #16076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
approved these changes
Feb 7, 2023
schmichael
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15864 changed the way in which the agent is passed to the HTTP servers by wrapping it in an interface. This removed access to the audit eventer, which is used by the HTTP server to log events for the enterprise codebase.
This change therefore explicitly passes the
event.Auditorinterface to the agent HTTP servers for use. This change will be needed along with an enterprise specific one, to slightly alter the audit calls to use the new field.Please see the internal nightly runs to see the original error.