Initial check state #1573
Initial check state #1573
Conversation
| @@ -770,6 +770,7 @@ func parseChecks(service *structs.Service, checkObjs *ast.ObjectList) error { | |||
| "port", | |||
| "command", | |||
| "args", | |||
| "status", | |||
There was a problem hiding this comment.
Can you add this to the parse test suite?
There was a problem hiding this comment.
I also think it is a little vague of a name. Maybe initial_status
There was a problem hiding this comment.
@dadgar should I rename it to InitialStatus everywhere? or just in parse.go?
There was a problem hiding this comment.
Everywhere for consistency please
|
@hoffoo Thanks! Added some comments, we are going to merge this after we get 0.4.1 out of the door. |
|
okay i made the changes, please let me know of anything else Thanks! |
|
@hoffoo Could you rebase and get this mergable? |
|
done! do you want me to open a squashed pr? not sure what the process is |
|
@hoffoo So your branch is behind our master, which is why there are so many extra commits in your PR which have already landed in |
hoffoo
force-pushed
the
initial_check_state
branch
from
f0d112b to
acc6c71
Compare
|
@diptanu sorry about that, new commit is ready |
hoffoo
force-pushed
the
initial_check_state
branch
from
acc6c71 to
6e94f68
Compare
hoffoo
force-pushed
the
initial_check_state
branch
from
6e94f68 to
20cce5e
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is an whack at #1239
Thanks!