bug: Handle missing policy documents in event streams #15495
Conversation
|
|
|
@wjnicholson is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Hi @wjnicholson! This approach seems reasonable.
But it seems from the discussion in #14058 that we might not necessarily want to keep the existing behavior of this on other endpoints, in which case this PR would be adding work we want to rip out later. I'm going to ping @jrasell on this, as he's recently worked on the Roles feature and may have more context than me.
Apologies for the delay. I think there is still some discussion to have on the issue and any change would come in an upcoming major release, and therefore not in the immediate term. I'm inclined to therefore say we should accept this change, which brings the stream inline with how policies work in the RPC and client caching. Any work on changing the existing behaviour would involve multiple subsystems, so this change I don't think adds too much more and the advantage of consistency seems like a good thing. |
tgross
added
backport/1.3.x
#16177) Fixes #15493 Co-authored-by: Will Nicholson <[email protected]>
To fix #15493
Will need a test too.