Output HostStatsCollector's Collect errors

[nak3]

No description provided.

[diptanu]

Let's remove the if/else statements.

memStats, err := mem.VirtualMemory()
....
if err != nil {
   return nil, err
}

[nak3]

@diptanu I agree that removing if/else statements. But return nil, err is OK?

if err != nil {
   return nil, err
}

I thought it should collect errors as below like you commented.

mErr.Errors = append(mErr.Errors, fmt.Errorf("error to collect cpu stats", err))

[diptanu]

@nak3 Yeah this is ok, since even if we collect more stats but return an error we won't update the stats.

[nak3]

@diptanu I see. Thank you.

[diptanu]

I initially didn't want to report any errors since I wanted to collect as much stats I could in the event stats collection of a particular sub-system was failing.

[nak3]

Here is a fix for gofmt error.

[diptanu]

Thanks!

[nak3]

@diptanu Thank you. I updated.

[diptanu]

hs.Memory := &MemoryStats {

[nak3]

@diptanu Thank you. I updated.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.