Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secure variable server configuration #13307

Merged
merged 1 commit into from
Jun 22, 2022
Merged

secure variable server configuration #13307

merged 1 commit into from
Jun 22, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 9, 2022 •
edited
Loading

Add fields for configuring root key garbage collection. Fix the
keystore path so that we write to a tempdir when in dev mode.

@tgross tgross added the theme/variables Variables feature label Jun 9, 2022
@tgross tgross added this to the 1.4.0 milestone Jun 9, 2022
@tgross tgross force-pushed the secure-variables branch from 784789b to a281a5e Compare June 14, 2022 17:59
@tgross tgross force-pushed the sv-server-config branch from 9fe9a0e to e852411 Compare June 14, 2022 18:13
@tgross tgross force-pushed the sv-server-config branch from e852411 to 61e2a3d Compare June 14, 2022 19:17
@tgross tgross force-pushed the sv-server-config branch 2 times, most recently from 49b6fae to 2cdb1f2 Compare June 21, 2022 18:25
@tgross tgross requested a review from angrycub June 21, 2022 18:26
@tgross tgross marked this pull request as ready for review June 21, 2022 18:26
@tgross tgross marked this pull request as draft June 21, 2022 19:18
@tgross tgross removed the request for review from angrycub June 21, 2022 19:18
@tgross
secure variable server configuration
0c15229 
Add fields for configuring root key garbage collection and automatic
rotation. Fix the keystore path so that we write to a tempdir when in
dev mode.
@tgross tgross force-pushed the sv-server-config branch from 2cdb1f2 to 0c15229 Compare June 21, 2022 19:35
@tgross tgross marked this pull request as ready for review June 21, 2022 19:52
@tgross tgross requested a review from angrycub June 21, 2022 19:52
angrycub
angrycub approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@angrycub angrycub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tgross tgross merged commit a270091 into secure-variables Jun 22, 2022
@tgross tgross deleted the sv-server-config branch June 22, 2022 13:31
tgross added a commit that referenced this pull request Jul 11, 2022
@tgross
secure variable server configuration (#13307)
d03fd4b 
Add fields for configuring root key garbage collection and automatic
rotation. Fix the keystore path so that we write to a tempdir when in
dev mode.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@angrycub angrycub angrycub approved these changes

Assignees
No one assigned
Labels
theme/variables Variables feature
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross @angrycub