Volume binds for windows containers

[mwieczorek]

Windows containers needs separate definition of paths for mounted volumes (with drive letters).
Without this patch we get an error during creating container, f.e.:

2016/06/18 13:50:54 [ERR] client: failed to start task 'redis' for alloc 'f66e0366-7137-7e29-9e11-3d21dceeaa4e': 
Failed to create container from image microsoft/sample-redis:nanoserver: API error (500): 
Invalid bind mount spec "C:\\Users\\vagrant\\AppData\\Local\\Temp\\NomadClient916164026\\f66e0366-7137-7e29-9e11-3d21dceeaa4e\\alloc:/alloc": 
Invalid volume specification: 'C:\Users\vagrant\AppData\Local\Temp\NomadClient916164026\f66e0366-7137-7e29-9e11-3d21dceeaa4e\alloc:/alloc'

[diptanu]

@mwieczorek Thanks for the PR! We will test this out once we make the 0.4 release over the next few days and merge this.

[mwieczorek]

@diptanu Any thoughts about it? Is it ok, or should I change something?

[diptanu]

Why are we hardcoding c:\\ here? I understand that this is the default, but users can specify any other drive such as D, E, etc as their Data Dir. Is this going to work in all cases?

[diptanu]

Well, I am not sure how bind mount sharing between containers and hosts work in windows. Can you please explain how the file system is laid out inside a windows container? So if it's always going to be C:\\ I think this is fine.

[diptanu]

@mwieczorek Sorry for taking so long. The PR looks good, but I have a question regarding the hard coded C:\\, once we can ensure that it's going to work properly I can merge this PR.

[mwieczorek]

@diptanu If I try with other drives (D:, E:, etc.) I get an error (something with win32).
I couldn't find anything in MS documentation so I asked about it here

Let's wait for the reply. I'll let you know about it.

[diptanu]

@mwieczorek Sounds good!

[diptanu]

@mwieczorek Also, probably worth asking the question on the docker project's mailing list/issues as well.

[mwieczorek]

@diptanu It's confirmed - we can only use C: drive.
Of course in the future if other drives will be supported we can change it also in Nomad.

[diptanu]

@mwieczorek Thanks for shepherding this!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.