Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of scheduler: volume updates should always be destructive into release/1.2.x #13010

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13008 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Fixes #12963

No task driver with file system isolation can support updating mounts in-place. Host volume and CSI volume or volume mount additions or updates should therefore always be destructive.


This changeset includes some unit testing but I've manually tested it on real CSI volumes as well. Adding a new volume:

$ nomad job plan ./demo/csi/hostpath/redis.nomad
+/- Job: "example"
+/- Task Group: "cache" (1 create/destroy update)
  +   Volume {
      + AccessMode:     "single-node-reader-only"
      + AttachmentMode: "file-system"
      + Name:           "volume0"
      + PerAlloc:       "true"
      + ReadOnly:       "true"
      + Source:         "test-volume"
      + Type:           "csi"
      }
  +/- Task: "redis" (forces in-place update)

Altering an existing volume:

$ nomad job plan ./demo/csi/hostpath/redis.nomad
+/- Job: "example"
+/- Task Group: "cache" (1 create/destroy update)
  +/- Volume {
    +/- AccessMode:     "single-node-reader-only" => "single-node-writer"
        AttachmentMode: "file-system"
        Name:           "volume0"
        PerAlloc:       "true"
    +/- ReadOnly:       "true" => "false"
        Source:         "test-volume"
        Type:           "csi"
      }
      Task: "redis"

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-volume-in-place/morally-eminent-worm branch from 673d90d to 0aef5b4 Compare May 13, 2022 15:34
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit e8007ff into release/1.2.x May 13, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-volume-in-place/morally-eminent-worm branch May 13, 2022 15:35
@shoenig shoenig mentioned this pull request Jun 2, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants