Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: plugin supervisor prestart should not mark itself done into release/1.2.x #12755

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12752 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Fixes #12744

The task runner hook Prestart response object includes a Done
field that's intended to tell the client not to run the hook
again. The plugin supervisor creates mount points for the task during
prestart and saves these mounts in the hook resources. But if a client
restarts the hook resources will not be populated. If the plugin task
restarts at any time after the client restarts, it will fail to have
the correct mounts and crash loop until restart attempts run out.

Fix this by not returning Done in the response, just as we do for
the volume_mount_hook.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-csi-plugin-after-client-restart/amazingly-hot-owl branch from 6bd9306 to 4439aed Compare April 22, 2022 17:08
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 8a51d24 into release/1.2.x Apr 22, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-csi-plugin-after-client-restart/amazingly-hot-owl branch April 22, 2022 17:08
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants