client: add Nomad template service functionality to runner. #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the template task runner to utilise the new consul-template which includes Nomad service lookup template funcs. In order to provide security and auth to consul-template, we use a custom HTTP dialer which is passed to consul-template when setting up the runner. This method follows Vault implementation.
schmichael
added a commit
to hashicorp/consul-template
that referenced
this pull request
Apr 6, 2022
Adds 2 functions for retrieving services from Nomad: - nomadServices - retrieves all services from Nomad - nomadService - retrieves all registrations for a service Tag filtering for `nomadService` is currently implemented in consul-template as the Nomad API does not support it directly. Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a binary built from the PR: hashicorp/nomad#12458 Tests also require Docker.
schmichael
approved these changes
Apr 6, 2022
Comment on lines
+916
to
+921
| // Set up a custom listener and dialer. This is used by Nomad clients when | ||
| // running consul-template functions that utilise the Nomad API. We lazy | ||
| // load this into the client config, therefore this needs to happen before | ||
| // we call NewClient. | ||
| a.builtinListener, a.builtinDialer = bufconndialer.New() | ||
| conf.TemplateDialer = a.builtinDialer |
| @@ -0,0 +1,48 @@ | |||
| // BufConnWrapper implements consul-template's TransportDialer using a | |||
There was a problem hiding this comment.
Oops, no tests. I'll try to get to that later today. #12483
schmichael
added a commit
to hashicorp/consul-template
that referenced
this pull request
Apr 7, 2022
Adds 2 functions for retrieving services from Nomad: - nomadServices - retrieves all services from Nomad - nomadService - retrieves all registrations for a service Tag filtering for `nomadService` is currently implemented in consul-template as the Nomad API does not support it directly. Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a binary built from the PR: hashicorp/nomad#12458 Tests also require Docker.
schmichael
added a commit
to hashicorp/consul-template
that referenced
this pull request
Apr 8, 2022
Adds 2 functions for retrieving services from Nomad: - nomadServices - retrieves all services from Nomad - nomadService - retrieves all registrations for a service Tag filtering for `nomadService` is currently implemented in consul-template as the Nomad API does not support it directly. Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a binary built from the PR: hashicorp/nomad#12458 Tests also require Docker.
schmichael
added a commit
to hashicorp/consul-template
that referenced
this pull request
Apr 12, 2022
Adds 2 functions for retrieving services from Nomad: - nomadServices - retrieves all services from Nomad - nomadService - retrieves all registrations for a service Tag filtering for `nomadService` is currently implemented in consul-template as the Nomad API does not support it directly. Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a binary built from the PR: hashicorp/nomad#12458 Tests also require Docker.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the template task runner to utilise the
new consul-template which includes Nomad service lookup template
funcs.
In order to provide security and auth to consul-template, we use
a custom HTTP dialer which is passed to consul-template when
setting up the runner. This method follows Vault implementation.
This PR also includes an E2E test in lieu of integration tests. This
is due to the taskrunner/template pkg being in a long import chain
making utilising current test agents/clients impossible without a
large refactor. We will therefore step back and address this
properly in the future.