Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set test log level off in gha #12381

Merged
merged 2 commits into from
Mar 25, 2022
Merged

ci: set test log level off in gha #12381

merged 2 commits into from
Mar 25, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Mar 25, 2022

Many of our tests do terrible things, causing many log lines even at ERROR level. From CI all we really want is the normal go test output with the line number of the failure. TestAgent still needed some plumbing for NOMAD_TEST_LOG_LEVEL to take affect.

includes #12379

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoenig shoenig merged commit 43b64b7 into main Mar 25, 2022
@shoenig shoenig deleted the ci-gha-off branch March 25, 2022 20:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants