-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.2.x] Onboard to CRT #12277
Conversation
echo "no files were updated" | ||
fi | ||
- name: Invoke build workflow | ||
uses: benc-uk/workflow-dispatch@4c044c1613fabbe5250deadc65452d54c4ad4fc7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using a workflow dispatch here, we could use the builtin workflow_run
.
See docs here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_runbranchesbranches-ignore
and here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
So the opening part of the build.yml would look like:
on:
workflow_run:
workflows: [Generate Static Assets]
types:
- completed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, this workflow would have to be on the default branch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpenfound - we tried this 😢 but unfortunately it only triggers on the default branch and we want this to run on commits to the release branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Sarah <[email protected]> Co-authored-by: Luiz Aoqui <[email protected]>
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Onboard Nomad OSS [
release/1.2.x
] to Common Release ToolingThere are a few important changes to call out in this PR:
GitHub Actions is being used as the CI provider to build the go binary artifacts and linux packages. This logic lives in .github/workflows/build.yml and workflow runs are available under https://github.com/hashicorp/nomad/actions.
Artifact builds will continue to run on PR's and merges to main. This behavior can be changed by updating the on: logic in the .github/workflows/build.yml file.
The .release/ci.hcl file contains some metadata for our release service. The only part you'll likely ever need to change is the release_branches array -- when you want to release off of a new release branch, update this value to the release branch name and be sure to update the branches array in .github/workflows/build.yml to the same value. This should be set to either main, the release branch that we'll be releasing off of (once release branches are adopted), or a test branch that you are working off of if you need to validate every part of the pipeline before merging.
This PR includes the Generate Static Assets workflow-- this workflow generates the static files that are needed for release day. It commits any generated static files that were made into the release branch. These files will either be committed (if files are generated) or no files will be pushed based on the changes that are pushed up.
generate-static-assets workflow run passed here:
This workflow then kicks off the build workflow which passed here:
You can see here that there were no files were updated (committed).