Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: initial docs for the new API features #12094

Merged
merged 3 commits into from
Mar 14, 2022
Merged

docs: initial docs for the new API features #12094

merged 3 commits into from
Mar 14, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Feb 19, 2022 •
edited
Loading

Provide documentation for the new filtering, sorting, and pagination features for the Nomad API. Filtering documentation adapted from Consul.

Documentation for reverse provided in #12244

@lgfa29 lgfa29 mentioned this pull request Mar 3, 2022
Merged
@lgfa29 lgfa29 force-pushed the docs-api-filter-page-sort branch from e941718 to fd52173 Compare March 9, 2022 01:50
@lgfa29 lgfa29 changed the base branch from main to f-api-consistent-sort March 9, 2022 01:50
@lgfa29 lgfa29 requested review from shoenig and tgross March 9, 2022 01:52
@lgfa29 lgfa29 added the theme/docs Documentation issues and enhancements label Mar 9, 2022
@lgfa29 lgfa29 marked this pull request as ready for review March 9, 2022 01:53
@lgfa29 lgfa29 force-pushed the f-api-consistent-sort branch from 8740dcb to bbe7ffe Compare March 9, 2022 01:57
@lgfa29 lgfa29 force-pushed the docs-api-filter-page-sort branch from fd52173 to e692221 Compare March 9, 2022 02:00
@lgfa29 lgfa29 force-pushed the docs-api-filter-page-sort branch from e692221 to c6739b7 Compare March 9, 2022 02:02
shoenig
shoenig approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 force-pushed the f-api-consistent-sort branch from bbe7ffe to 9c2db51 Compare March 11, 2022 22:22
Base automatically changed from f-api-consistent-sort to main March 12, 2022 00:44
@lgfa29 lgfa29 force-pushed the docs-api-filter-page-sort branch from c6739b7 to 0e8d8e0 Compare March 14, 2022 14:41
@lgfa29 lgfa29 merged commit ebbbedd into main Mar 14, 2022
@lgfa29 lgfa29 deleted the docs-api-filter-page-sort branch March 14, 2022 14:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@tgross tgross Awaiting requested review from tgross

Assignees
No one assigned
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgfa29 @shoenig