CSI: move terminal alloc handling into denormalization #11931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-refactoring-pr
branch
from
87f65a3 to
11f7694
Compare
tgross
force-pushed
the
csi-refactoring-pr
branch
from
11f7694 to
d4670ad
Compare
tgross
force-pushed
the
csi-refactoring-pr
branch
from
d4670ad to
ec95b3f
Compare
tgross
force-pushed
the
csi-refactoring-pr
branch
from
ec95b3f to
3cfcea6
Compare
The volume claim GC method and volumewatcher both have logic collecting terminal allocations that duplicates most of the logic that's now in the state store's `CSIVolumeDenormalize` method. Copy this logic into the state store so that all code paths have the same view of the past claims. (1/4 refactoring commits)
Remove logic in the volume claim GC that now lives in the state store's `CSIVolumeDenormalize` method. (2/4 refactoring commits)
Remove logic in the volumewatcher that now lives in the state store's `CSIVolumeDenormalize` method. (3/4 refactoring commits)
Remove logic in the node unpublish RPC that now lives in the state store's `CSIVolumeDenormalize` method. (4/4 refactoring commits)
tgross
force-pushed
the
csi-refactoring-pr
branch
from
3cfcea6 to
f223bf7
Compare
This was referenced Jan 28, 2022
tgross
added a commit
that referenced
this pull request
Jan 28, 2022
* The volume claim GC method and volumewatcher both have logic collecting terminal allocations that duplicates most of the logic that's now in the state store's `CSIVolumeDenormalize` method. Copy this logic into the state store so that all code paths have the same view of the past claims. * Remove logic in the volume claim GC that now lives in the state store's `CSIVolumeDenormalize` method. * Remove logic in the volumewatcher that now lives in the state store's `CSIVolumeDenormalize` method. * Remove logic in the node unpublish RPC that now lives in the state store's `CSIVolumeDenormalize` method.
tgross
added a commit
that referenced
this pull request
Jan 28, 2022
* The volume claim GC method and volumewatcher both have logic collecting terminal allocations that duplicates most of the logic that's now in the state store's `CSIVolumeDenormalize` method. Copy this logic into the state store so that all code paths have the same view of the past claims. * Remove logic in the volume claim GC that now lives in the state store's `CSIVolumeDenormalize` method. * Remove logic in the volumewatcher that now lives in the state store's `CSIVolumeDenormalize` method. * Remove logic in the node unpublish RPC that now lives in the state store's `CSIVolumeDenormalize` method.
|
Removed the |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR has been split off from #11890 and #11932 to make the core idea of those PRs more understandable.
The core GC job and volumewatcher will have logic that largely duplicates logic in the state store's
CSIVolumeDenormalizemethod. The only missing part is the handling of terminal allocations, so this changeset moves that logic into theCSIVolumeDenormalizemethod so it exists in only one place. Best reviewed commit-by-commit.