Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure consistent file naming for non-enterprise files. #11842

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 13, 2022

Files mostly use the _oss.go pattern apart from these ones, which
confused me for a moment when I first came across one. I also fixed-up
the unused function param style where needed.

@jrasell jrasell requested review from jazzyfresh and tgross January 13, 2022 10:55
@jrasell jrasell self-assigned this Jan 13, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We used to have _pro.go suffixes for the weird middle-of-the-road ENT builds but I just checked the ENT repo and those are all gone now.

@jrasell jrasell merged commit 8f01d74 into main Jan 14, 2022
@jrasell jrasell deleted the b-name-oss-files-consistently branch January 14, 2022 07:13
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants