CSI: tests to exercise csi_hook #11788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
approved these changes
Jan 7, 2022
Small refactoring of the allocrunner hook for CSI to make it more testable, and a unit test that covers most of its logic.
tgross
added a commit
that referenced
this pull request
Jan 28, 2022
Small refactoring of the allocrunner hook for CSI to make it more testable, and a unit test that covers most of its logic.
tgross
added a commit
that referenced
this pull request
Jan 28, 2022
Small refactoring of the allocrunner hook for CSI to make it more testable, and a unit test that covers most of its logic.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring of the allocrunner hook for CSI to make it more testable, and a unit test that covers most of its logic. These tests have uncovered a bug #11786 which I'm going to tackle as part of the work I'm doing on #10833 and #10927