Enable consul script checks for raw_exec driver #1159
Conversation
| @@ -586,6 +586,20 @@ func (e *UniversalExecutor) createCheck(check *structs.ServiceCheck, checkID str | |||
| }, nil | |||
|
|
|||
| } | |||
|
|
|||
| if check.Type == structs.ServiceCheckScript && e.ctx.Driver == "raw_exec" { | |||
There was a problem hiding this comment.
Ah, this was an overlook. Can you just merge this if statement with the previous branch of code that checks for the exec driver please?
if check.Type == structs.ServiceCheckScript && (e.ctx.Driver == "raw_exec" || e.ctx.Driver == "exec" || e.ctx.Driver == "java")
There was a problem hiding this comment.
Ready! Sorry for to many commits. Did not notice additional "java" condition at first.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Hi, I use nomad on windows platform. raw_exec is the only available driver there and it is fine to me. This request enables consul script checks that does not work currently with raw_exec