Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickable links in allocations chart #11578

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

ChaiWithJai
Copy link
Contributor

The spec calls for editing the Allocation Status Chart to look more like the Job Client Status Chart. However, the surface area of the Allocation Status Chart spans much further than the Job Client Status Chart as it appears in severals rows throughout the application, as well as, in the Task Group page.

Additionally, the linking capability requested by this feature requires getting the context of a job (and its associated namespace).

Until, we have clarity regarding the surface area of the requested changes: is this change scoped only to the Job Detail Overview page or everywhere that we are rendering an Allocation Status Summary chart, we can't complete the work for adding links to the legend chart (and reformatting the legend).

Spec:

image

@ChaiWithJai ChaiWithJai linked an issue Nov 25, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Ember Asset Size action

As of 094c191

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +912 B +111 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Ember Test Audit comparison

f-ui/add-filters-to-allocs 094c191 change
passes 1199 1195 -4
failures 0 1 +1
flaky 0 4 +4
duration 9m 46s 873ms 000ms -9m 46s 873ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 60140c5:

  • Acceptance | job dispatch (with namespace): required meta fields are properly indicated

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 094c191:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

Copy link
Contributor

@LevelbossMike LevelbossMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Base automatically changed from f-ui/add-filters-to-allocs to main December 18, 2021 14:38
@ChaiWithJai ChaiWithJai requested review from lgfa29 and a team December 20, 2021 13:51
Copy link

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ChaiWithJai ChaiWithJai merged commit 0ec5db4 into main Dec 20, 2021
@ChaiWithJai ChaiWithJai deleted the f-ui/clickable-links-allocs branch December 20, 2021 15:08
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clickable links in allocation summary
3 participants