-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clickable links in allocations chart #11578
Conversation
Ember Asset Size actionAs of 094c191 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on 60140c5:
|
60140c5
to
094c191
Compare
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on 094c191:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The spec calls for editing the Allocation Status Chart to look more like the Job Client Status Chart. However, the surface area of the Allocation Status Chart spans much further than the Job Client Status Chart as it appears in severals rows throughout the application, as well as, in the Task Group page.
Additionally, the linking capability requested by this feature requires getting the context of a job (and its associated namespace).
Until, we have clarity regarding the surface area of the requested changes: is this change scoped only to the Job Detail Overview page or everywhere that we are rendering an Allocation Status Summary chart, we can't complete the work for adding links to the legend chart (and reformatting the legend).
Spec: