auth_soft_fail needed for public images when agent is configured with auth

[shantanugadgil]

auth_soft_fail needed for public image when agent is configured with auth

[lgfa29]

Thanks @shantanugadgil 🙂

I don't know why we space out the config block. Maybe we can set it to be more compact like this? What do you think?

config {
  image = "redis:3.2"
  ports = ["db"]
                        
  auth_soft_fail = true
}

[shantanugadgil]

Thanks @shantanugadgil slightly_smiling_face

I don't know why we space out the config block. Maybe we can set it to be more compact like this? What do you think?

config {
  image = "redis:3.2"
  ports = ["db"]
                        
  auth_soft_fail = true
}

I am fine with the above change you have proposed.

or even something like:

config {
  image          = "redis:3.2"
  ports          = ["db"]
  auth_soft_fail = true
}

Side note, after some grepping, I discovered there could be more "example" files in code which would need this fix though.

[lgfa29]

Thanks @shantanugadgil slightly_smiling_face
I don't know why we space out the config block. Maybe we can set it to be more compact like this? What do you think?

config {
  image = "redis:3.2"
  ports = ["db"]
                        
  auth_soft_fail = true
}

I am fine with the above change you have proposed.

or even something like:

config {
  image          = "redis:3.2"
  ports          = ["db"]
  auth_soft_fail = true
}

Yeah, I think that works as well.

Side note, after some grepping, I discovered there could be more "example" files in code which would need this fix though.

Good point. I think connect.nomad and connect-short.nomad would need them as well. Any other reference to the example job I think would OK since command/assets is the path used by the nomad job init command.

Where else were you thinking about changing?

[shantanugadgil]

@lgfa29 I have now modified all .nomad files inside command/assets/.

[lgfa29]

Thanks @shantanugadgil!

I pushed a commit to simplify the comment text a little. I also removed the second comment from the Connect example since it's already set in the first task.

Does the new comment text still makes sense?

[lgfa29]

I forgot to actually accept and merge.

Thank you @shantanugadgil!

[shantanugadgil]

Thanks. the comments seem fine. Punctuation can be bettered, but having that option in there is more important! 👍

[shantanugadgil]

@lgfa29 this change doesn't appear even with the latest GA 1.3.1. I am not sure why the assets are not being used correctly! :(

# nomad --version
Nomad v1.3.1 (2b054e38e91af964d1235faa98c286ca3f527e56)

# nomad job init -short 
Example job file written to example.nomad

# vim example.nomad

---
 11     task "redis" {
 12       driver = "docker"
 13 
 14       config {
 15         image = "redis:3.2"
 16 
 17         ports = ["db"]
 18       }
 19 
---

[lgfa29]

Oh that's weird...I'm not sure why the generate file was not updated during the release process. We call make prerelease, which calls generate-all, which then calls generate-examples, which was supposed to update the command/job_init.bindata_assetfs.go file with the new binary data.

I think that, because the file already exists, make doesn't try to recreate 🤔

I will investigate this further, thanks for let me know!

[shantanugadgil]

Just wondering if you were able to determine the issue with the assets.

[lgfa29]

Just wondering if you were able to determine the issue with the assets.

Sorry, I missed this 😅

I didn't find the root cause, but manually fixed. I should be there in 1.3.2.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.