Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysbatch UI luiz #11094

Merged
merged 6 commits into from
Aug 30, 2021
Merged

sysbatch UI luiz #11094

merged 6 commits into from
Aug 30, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 27, 2021

No description provided.

@lgfa29 lgfa29 requested a review from ChaiWithJai August 27, 2021 21:31
@github-actions
Copy link

github-actions bot commented Aug 27, 2021

Ember Asset Size action

As of 91a17cb

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +4.68 kB -175 B
nomad-ui.css +12 B +1 B

Files that got Smaller 🎉:

File raw gzip
vendor.js -72.6 kB -24.7 kB

Files that stayed the same size 🤷‍:

File raw gzip
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 27, 2021

Ember Test Audit comparison

f-sysbatch-ui 3c50ac7 change
passes 1048 1107 +59
failures 45 0 -45
flaky 15 0 -15
duration 000ms 7m 35s 702ms +7m 35s 702ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on f-sysbatch-ui:

  • Acceptance | allocation detail (preemptions): shows a dedicated section to the allocation that preempted this allocation
  • Acceptance | job definition: when changes are submitted, the site redirects to the job overview page
  • Acceptance | job detail (with namespaces): when the dynamic autoscaler is applied, you can scale a task within the job detail page
  • Acceptance | job versions: all versions but the current one have a button to revert to that version
  • Acceptance | jobs list: each job row should link to the corresponding job
  • Acceptance | regions (only one): api requests do not include the region query param
  • Acceptance | regions (many): when the region is not the default region, all api requests other than the agent/self request include the region query param
  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on f-sysbatch-ui:

  • Acceptance | allocation detail: /allocation/:id should name the allocation and link to the corresponding job and node
  • Acceptance | allocation detail (preemptions): shows a dedicated section to the allocation that preempted this allocation
  • Acceptance | client detail: each allocation should link to the job the allocation belongs to
  • Acceptance | job definition: when changes are submitted, the site redirects to the job overview page
  • Acceptance | job detail (with namespaces): the exec button state can change between namespaces
  • Acceptance | job detail (with namespaces): when the dynamic autoscaler is applied, you can scale a task within the job detail page
  • Acceptance | job versions: all versions but the current one have a button to revert to that version
  • Acceptance | search: search exposes and navigates to results from the fuzzy search endpoint
  • Acceptance | task detail (different namespace): breadcrumbs match jobs / job / task group / allocation / task
  • Acceptance | task detail (not running): when the allocation for a task is not running, the resource utilization graphs are replaced by an empty message
  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Acceptance | tokens: when the ott query parameter is present upon application load it’s exchanged for a token
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@ChaiWithJai ChaiWithJai merged commit aaac85a into f-sysbatch-ui Aug 30, 2021
@ChaiWithJai ChaiWithJai deleted the f-sysbatch-ui-luiz branch August 30, 2021 13:03
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants