ui: Add more exposure of memory_max #10508
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 6ba1052 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
This appears to have no tests…? 🤔 Or everything is broken locally, which is sadly not unlikely
It’s preferable to have it stored as 0 so it can be known that oversubscription is disabled.
Is `this.tracker.reservedMemoryMax` even valid? 🤔
backspace
force-pushed
the
f-ui/memory_max-exposure
branch
from
b338936 to
6352281
Compare
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on b43b87f:
|
This is a reversion from #10459, more background here: #10268 (comment)
mehhhhhhhhhh
This shouldn’t assume a maximum is present. Maybe it should be conditional…? 🧐
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on 6ba1052:
|
|
@JBhagat841 I'm assigning this to you just so that we don't lose track of open PRs from Buck, but there's no special rush on it other than that we should try to ship it in the 1.1.x cycle. |
|
|
tgross
added
the
stage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #10268, focusing on exposing information via memory metrics charts.
When
memory_maxis configured for a task and oversubscription is enabled, the allocation response’sAllocatedResources.Tasks[].MemoryMaxMB(which maps toallocation.states[].resources.memoryMaxin Ember Data representations) will be non-zero, and when it exceeds….resources.memory, a soft limit annotation shows on the task’s memory primary metric chart:Similarly, it shows on the allocation memory primary metric chart for the aggregated tasks:
While working on this, I decided that it didn’t make sense to show the configured maximum in the task group details ribbon as I added in #10268 because it would always show, even when oversubscription wasn’t enabled.
AllocatedResourcesis the way to know the discrepancy between configured and actual limits, so it’s not possible to only show the maximum on the task group details page when oversubscription is enabled, as task groups can’t know their “reified” (?) resources.