e2e: add e2e tests for consul namespaces on ent with acls #10439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
pick-ent-acls-changes
branch
from
f7a5efe to
301735a
Compare
shoenig
force-pushed
the
pick-ent-acls-changes
branch
from
301735a to
1b5c1f0
Compare
tgross
requested changes
Apr 27, 2021
e2e/consul/namespaces_acls_ent.go
Outdated
| @@ -0,0 +1,564 @@ | |||
| // +build ent | |||
There was a problem hiding this comment.
Yikes, nope! It's gone now >_>
This PR adds e2e tests for Consul Namespaces for Nomad Enterprise with Consul ACLs enabled. Needed to add support for Consul ACL tokens with `namespace` and `namespace_prefix` blocks, which Nomad parses and validates before tossing the token. These bits will need to be picked back to OSS.
shoenig
force-pushed
the
pick-ent-acls-changes
branch
from
1b5c1f0 to
4605fca
Compare
tgross
approved these changes
Apr 28, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hold until ent half goes in - making sure oss CI still works)This PR cherry-picks changes made for ENT testing of Consul Namespaces with ACLs enabled.