Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flakey exec test that tests non-deterministic docker behavior #10291

Merged
merged 1 commit into from
Apr 2, 2021
+0 −9
Merged

remove flakey exec test that tests non-deterministic docker behavior #10291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions plugins/drivers/testutils/exec_testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,6 @@ var ExecTaskStreamingBasicCases = []struct {
Stdout: "hello from command\nhello from stdin\n",
ExitCode: 0,
},
{
Name: "notty: children processes",
Command: "(( sleep 3; echo from background ) & ); echo from main; exec sleep 1",
Tty: false,
// when not using tty; wait for all processes to exit matching behavior of `docker exec`
Stdout: "from main\nfrom background\n",
ExitCode: 0,
},

// TTY cases - difference is new lines add `\r` and child process waiting is different
{
Name: "tty: basic",
Expand Down