cli: authenticate to the Nomad web UI via the CLI #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
approved these changes
Mar 8, 2021
The `OneTimeToken` struct is to support the `nomad ui -login` command. This changeset adds the struct to the Nomad state store.
RPC endpoints for the user-driven APIs (`UpsertOneTimeToken` and `ExchangeOneTimeToken`) and token expiration (`ExpireOneTimeTokens`). Includes adding expiration to the periodic core GC job.
Endpoints for requesting and exchanging one-time tokens via the HTTP API. Includes documentation updates.
Includes swapping the previously documented `-login` flag for `-authenticate` to align better with Waypoint.
|
I've rebased this into cleaner commits that can all get rebase-merged to |
This was referenced Mar 10, 2021
backspace
added a commit
that referenced
this pull request
Apr 1, 2021
This adds UI support for receiving the one-time token passed via query parameter, as in #10134 and related PRs, and exchanging it for its corresponding secret ID. When this works, it’s mostly invisible, with a brief flash of the OTT onscreen. The authentication failure message now suggests the -authenticate flag. When OTT exchange fails, it shows a whole-page error. This includes a known UX shortcoming in that the OTT will not disappear from the URL when an identifier is specified on the command line, like nomad ui -authenticate jobname. The goal is to address that shortcoming in a forthcoming pull request.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR for the feature branch inclusive of all work except for the web UI work being done by @backspace in #10066. This PR contains the work previously reviewed in #10066 #10091 #10092 #10095 and #10097.