Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: wildcard services in IGCE more restricted than consul #9729

Closed
shoenig opened this issue Jan 5, 2021 · 1 comment · Fixed by #10457
Closed

connect: wildcard services in IGCE more restricted than consul #9729

shoenig opened this issue Jan 5, 2021 · 1 comment · Fixed by #10457
Assignees
Labels
hcc/cst Admin - internal theme/consul/connect Consul Connect integration type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Jan 5, 2021

This ingress gateway configuration entry is allowed by Consul, exposing all services through the listener and allowing omission of the Hosts field.

Kind = "ingress-gateway"
Name = "my-ingress-service"
Listeners = [
  {
    Port     = 9090
    Protocol = "http"
    Services = [
     {
       Name = "*"
     }
   ]
  }
]

Nomad doesn't respect the wildcard behavior, instead asserting one or more hosts must be defined when using http protocol. Nomad should behave like Consul here.

https://www.consul.io/docs/agent/config-entries/ingress-gateway#name-1

@shoenig shoenig added theme/consul/connect Consul Connect integration type/bug labels Jan 5, 2021
@shoenig shoenig self-assigned this Jan 5, 2021
@tgross tgross added the hcc/cst Admin - internal label Jan 26, 2021
shoenig added a commit that referenced this issue Apr 27, 2021
… services

This PR fixes a bug where Nomad was more restrictive on Ingress Gateway Configuration
Entry definitions than Consul. Before, Nomad would not allow for declaring IGCEs with
http listeners with service name "*", which is a special feature allowable by Consul.

Note: to make http protocol work, a service-default must be defined setting the
protocol to http for each service.

Fixes: #9729
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hcc/cst Admin - internal theme/consul/connect Consul Connect integration type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants