Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact stanza doesn't support AWS S3 virtual host style paths #9050

Closed
picatz opened this issue Oct 8, 2020 · 5 comments · Fixed by #9349
Closed

Artifact stanza doesn't support AWS S3 virtual host style paths #9050

picatz opened this issue Oct 8, 2020 · 5 comments · Fixed by #9349

Comments

@picatz
Copy link
Contributor

picatz commented Oct 8, 2020

Related to hashicorp/go-getter#263 and #8454, valid S3 paths fail when used in the artifact stanza. This is a real pain to spot, due to the slight difference in newer S3 paths. Moreover, new S3 buckets now must be referenced using the new format.

@picatz
Copy link
Contributor Author

picatz commented Nov 12, 2020

Related PR to fix this in go-getter: hashicorp/go-getter#283

@picatz
Copy link
Contributor Author

picatz commented Nov 12, 2020

I reviewed / merged hashicorp/go-getter#283 after verifying it locally.

😭 Trying to cut a v1.5.1 release of go-getter is failing though: https://github.com/hashicorp/go-getter/runs/1392538444

@picatz
Copy link
Contributor Author

picatz commented Nov 12, 2020

Tests removed! hashicorp/go-getter#293

😅 But the release process will probably still fail for the time being because Apple's notarization service is currently down. It will need to be re-run once it's back up.

@picatz
Copy link
Contributor Author

picatz commented Nov 12, 2020

go-getter fix is now available in v1.5.1 -- need to make a PR to update here.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants