Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search navigates to wrong job url when job name contains spaces #8548

Closed
optiz0r opened this issue Jul 28, 2020 · 2 comments · Fixed by #8560
Closed

Global search navigates to wrong job url when job name contains spaces #8548

optiz0r opened this issue Jul 28, 2020 · 2 comments · Fixed by #8560

Comments

@optiz0r
Copy link
Contributor

optiz0r commented Jul 28, 2020

Nomad version

Nomad v0.12.1

Issue

When using the global search to find a job whose name contains a space, clicking on the result leads to a 404 page. The url includes %20 where the spaces are. By contrast, when looking at the jobs list and clicking on an entry for the same job, the url contains - in place of the spaces. Looks like the global search results do not calculate the destination URLs in the same way that the server does/expects.

Reproduction steps

  • Create a job with a space in the name
  • Search for part of that job name in the global search
  • Click the search result
  • Get taken to a 404
backspace added a commit that referenced this issue Jul 29, 2020
This fixes #8548. It was a significant oversight to use the
name instead of the id!
@backspace
Copy link
Contributor

Thanks for letting us know about this, @optiz0r. There being a space is a red herring, the true problem is that it was navigating based on the job name instead of the “plain id”! 😱 I’ve opened a PR with a fix.

backspace added a commit that referenced this issue Jul 30, 2020
This fixes #8548. It was a significant oversight to use the
name instead of the id!
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants