-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor fsouza/go-docker-client update #7550
Conversation
Also, since github.com/docker/docker is the canonical package names and is transparently forwarded to github.com/moby/moby, I removed the moby/moby references in origin.
This looks like it still has Windows build issues:
and some Linux build issues:
|
@tgross sorry - I need to fix CI first before requesting review :( . |
Use docker master branch for specific branches, so we can pick up the fix in moby/moby#40021 .
MemorySwappiness can only be set in non-Windows options: https://ci.appveyor.com/project/hashicorp/nomad/builds/31832149 Also fixes #6085
This is ready for review again - all green and is passing Windows appveyor tests too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@notnoop brilliant! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Reprise of #7416. Thanks @greut .
Also, includes some docker vendoring tweaks to ensure that all
github.com/docker/docker
packages are of v19.03.8Also fixes #6085