Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: fsouza/go-docker-client v1.6.3 #7416

Merged
merged 7 commits into from
Mar 23, 2020
Merged

vendor: fsouza/go-docker-client v1.6.3 #7416

merged 7 commits into from
Mar 23, 2020

Conversation

greut
Copy link
Contributor

@greut greut commented Mar 22, 2020 •
edited
Loading

Use latest version of go-dockerclient and fix some discrepancies in the docker/docker dependency list.

Could be useful for #6522

Snap I had to go back to a situation where the docker libraries are from different commits...

notnoop
notnoop approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, and your dedication as you work through this. Have a couple of small questions and I'll double check too - will merge after I do my homework by Monday.

vendor/vendor.json Outdated Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
notnoop
notnoop approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful - thanks a lot!

@notnoop notnoop merged commit 382bbbe into hashicorp:master Mar 23, 2020
@greut greut deleted the bump-go-dockerclient branch March 23, 2020 12:39
@notnoop notnoop mentioned this pull request Mar 23, 2020
Merged
@notnoop notnoop mentioned this pull request Mar 30, 2020
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greut @notnoop @pruett