Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Proxy Kind is not interpolated #6853

Closed
schmichael opened this issue Dec 12, 2019 · 1 comment · Fixed by #6855
Closed

Connect Proxy Kind is not interpolated #6853

schmichael opened this issue Dec 12, 2019 · 1 comment · Fixed by #6855
Assignees
@schmichael
Labels
theme/client theme/consul/connect Consul Connect integration type/bug
Milestone
0.10.4

Comments

@schmichael
Copy link
Member

Nomad version

0.10.2

Issue

When validating jobs on submission the service names are interpolated but the task kind is not.

This means if a service names uses an interpolated value such as ${JOB} a Connect-enabled job will fail to validate with the error:

Connect proxy service name not found in services from task group

Augmenting the error message with details makes the difference of interpolation obvious:

Connect proxy service name ("count-${JOB}") not found in services from task group: count-countdash

Job file (if appropriate)

Just add ${JOB} to the service name in the example Connec job: https://gist.github.com/schmichael/c22e696d6dca0ed585d98ab7a7e2fe63
@schmichael schmichael added this to the 0.10.3 milestone Dec 12, 2019
@schmichael schmichael self-assigned this Dec 12, 2019
@schmichael schmichael mentioned this issue Dec 12, 2019
Merged
schmichael added a commit that referenced this issue Dec 13, 2019
@schmichael
connect: canonicalize before adding sidecar
c74de6a 
Fixes #6853

Canonicalize jobs first before adding any sidecars. This fixes a bug
where sidecar tasks were added without interpolated names and broke
validation. Sidecar tasks must be canonicalized independently.

Also adds a group network to the mock connect job because it wasn't a
valid connect job before!
@shoenig shoenig mentioned this issue Dec 9, 2020
Merged
shoenig added a commit that referenced this issue Dec 9, 2020
@shoenig
consul/connect: interpolate connect block
4d0e745 
This PR enables job submitters to use interpolation in the connect
block of jobs making use of consul connect. Before, only the name of
the connect service would be interpolated, and only for a few select
identifiers related to the job itself (#6853). Now, all connect fields
can be interpolated using the full spectrum of runtime parameters.

Note that the service name is interpolated at job-submission time,
and cannot make use of values known only at runtime.

Fixes #7221
@hashicorp hashicorp deleted a comment Dec 10, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schmichael schmichael

Labels
theme/client theme/consul/connect Consul Connect integration type/bug
Projects
None yet
Milestone
0.10.4
Development

Successfully merging a pull request may close this issue.

connect: canonicalize before adding sidecar hashicorp/nomad
1 participant
@schmichael