Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Restart stopped job #4615

Merged
merged 5 commits into from
Aug 30, 2018
Merged

Conversation

DingoEatingFuzz
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz commented Aug 24, 2018

This is part of the larger UI Job Writes project #4600

Today it's possible to stop a job from the UI. Now it's possible to start that stopped job. Full circle!

stop-and-start

The diff is much larger than it should be because this branch is based off of #4612 to get the job update API code.

The diff is accurate now.

@DingoEatingFuzz DingoEatingFuzz requested a review from a team August 24, 2018 21:09
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Aug 24, 2018
5 tasks
@DingoEatingFuzz DingoEatingFuzz force-pushed the f-ui-restart-stopped-job branch from c15e01a to f4ceb22 Compare August 28, 2018 18:28
Copy link

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature is easy to follow, good test coverage 👍

I have an untested refactor suggestion for the two-step-button component, which may not work, and may not be helpful 😅

ui/app/components/two-step-button.js Show resolved Hide resolved
@DingoEatingFuzz DingoEatingFuzz merged commit 334358a into f-ui-job-writes Aug 30, 2018
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui-restart-stopped-job branch August 30, 2018 16:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants