UI: Edit a job #4612
UI: Edit a job #4612
Conversation
The lowest valid blocking query index is 1, but the API will return 0 if there has yet to be an index set (no response). This in conjunction with that 0 being stored as a string made the "fallback to 1" guard not work.
Caused by the re-indexing that occurs to remove zero-value bars.
Instead it was using the page-layout is-right div
…eeded This exports a function that returns the pertinent function when given a container. This way it works in registerHelper and in integration tests beforeEach hooks
Most of this was ported over from the existing job run acceptance tests
| onSubmit(id, namespace) { | ||
| this.transitionToRoute('jobs.job', id, { | ||
| queryParams: { jobNamespace: namespace }, | ||
| }); |
There was a problem hiding this comment.
This might be a stupid question, but bear with me. I think these methods are used as actions in the template, so why aren't they part of an actions object in the controller?
There was a problem hiding this comment.
I'm experimenting with the usefulness of the actions object. Trying to see if I can get away with only using the actions object when I actually have to, which I imagine is rarely if not never.
I'd like to hear your thoughts on the experiment!
| set(key, value) { | ||
| const allowedValues = ['new', 'edit']; | ||
|
|
||
| assert(`context must be one of: ${allowedValues.join(', ')}`, allowedValues.includes(value)); |
There was a problem hiding this comment.
My kingdom for static type checking.
This took me a minute to understand. If you find yourself doing this a lot, it might reduce the local noise to extract to a computed util (like the excellent localStorageProperty).
There was a problem hiding this comment.
Totally agree. Something like whitelistProperty(val1, val2, val3). I'm honestly not happy at all with this component. I didn't want to spend too much time thinking about how best to refactor it to not have this concept of "contexts", so I just went with it.
This looks to me to be a route-not-taken in #4612.
This is an extraneous addition from #4612.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is a part of the larger Job Writes in the UI project #4600
This is very similar to the Run Job UI, but it's for editing a job. Those of you familiar with Nomad know that editing a job and running a job is nearly the same. This just offers guarantees that you won't accidentally make a new job similar to the one you are editing.
The edit button lives on the Job Definition page, which seems like a good place for it.
Reviewer notes:
Somehow, even though I knew I was going to do this work, I ended up with non-trivial refactor 🤦♂️ . I moved what was the Run controller to a new Job Editor component and I moved/rewrote the tests that were once Run Page Acceptance Tests to be Job Editor Integration Tests.