Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize renewing non-renewable Vault lease as fatal #3727

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Recognize renewing non-renewable Vault lease as fatal #3727

merged 1 commit into from
Jan 10, 2018

Conversation

filipochnik
Copy link
Contributor

@filipochnik
Copy link
Contributor Author

Looks like some flaky tests failed, they pass on my machine.

@dadgar
Copy link
Contributor

dadgar commented Jan 10, 2018

@filipochnik Thanks! Looks great!

@dadgar dadgar merged commit 01b1ab4 into hashicorp:master Jan 10, 2018
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipochnik @dadgar