Nomad fails to identify Vault renewal error as fatal

[wlonkly]

Nomad version

Nomad v0.5.6

Operating system and Environment details

Ubuntu 16.06 (Xenial), Vault v0.6.4

Issue

When issued a nonrenewable token, Nomad client fails to recognize the Vault error as fatal, and continues trying to renew the token.

This may be as simple as this code not matching "lease is not renewable"? ie, it handles this vault error condition but not this one.).

Reproduction steps

1. Accidentally configure Vault's token role policy to issue nonrenewable tokens:

Key                	Value
---                	-----
[...]
renewable          	false

2. Run a Nomad job which integrates with Vault
3. Wait for the Nomad client to attempt to renew the token lease

Nomad Client logs (if appropriate)

Jul 13 20:53:36 stg-clustermgr-client30 nomad[1333]:     2017/07/13 20:53:36.804127 [ERR] client.vault: renewal of lease or token failed due to a non-fatal error. Retrying at 2017-07-13 20:53:49.804110836 +0000 UTC: failed to renew the vault token: Error making API request.
Jul 13 20:53:36 stg-clustermgr-client30 nomad[1333]: URL: PUT https://vault.query.consul:8200/v1/auth/token/renew-self
Jul 13 20:53:36 stg-clustermgr-client30 nomad[1333]: Code: 400. Errors:
Jul 13 20:53:36 stg-clustermgr-client30 nomad[1333]: * lease is not renewable

[dadgar]

Thanks for the great report. Will look into it 👍

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.