Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nomad server health check #2701

Closed
schmichael opened this issue Jun 9, 2017 · 2 comments
Closed

Fix Nomad server health check #2701

schmichael opened this issue Jun 9, 2017 · 2 comments

Comments

@schmichael
Copy link
Member

I think I caused a regression in #2467 -- from gitter:

git blame points to your commit 77d9b41 apparently before that change, servers did /v1/status/peers and clients /v1/agent/servers, but it got consolidated into /v1/agent/servers, which seems to be implemented in client only - so consul server health checks will fail on trunk
would it make sense to just switch the URI back to /v1/status/peers, as that seems to be a "generic" status check endpoint?

@schmichael schmichael added this to the v0.6.0 milestone Jun 9, 2017
@schmichael schmichael self-assigned this Jun 9, 2017
@shilov
Copy link

shilov commented Jun 12, 2017

Can confirm this is causing "Nomad Client HTTP Check" to fail for nomad agents running in server mode.

As implied, changing /v1/agent/servers to /v1/status/peers in command/agent/agent.go fixes the issue.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants