Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] When a job is deleted in the background, wait until redirect before cache unload #23492

Merged

Conversation

philrenaud
Copy link
Contributor

This prevents an issue where, still on the job page, the cache-removed job would have trouble accessing properties and relationships of its now-removed Ember Data object.

Resolves #23410

@philrenaud philrenaud self-assigned this Jul 2, 2024
@philrenaud philrenaud linked an issue Jul 2, 2024 that may be closed by this pull request
@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Ember Test Audit comparison

main 16fb206 change
passes 1573 1573 0
failures 0 0 0
flaky 0 0 0
duration 11m 35s 957ms 11m 27s 219ms -08s 738ms

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change, but it looks like it broke a related test.

@philrenaud
Copy link
Contributor Author

Broken test is now fixed; was related to a core piece of Ember's transition-handling where a transition can happen at both a high level (the application route has one) and a low level (the redirect we're patching up here) and the former is left "floating". A try/catch block prevents the uncaught failure.

@philrenaud philrenaud force-pushed the 23410-ui-cannot-close-task-sidebar-if-job-was-deleted branch from a4cb34a to 16fb206 Compare July 3, 2024 20:47
@philrenaud philrenaud merged commit 7cf6332 into main Jul 4, 2024
15 checks passed
@philrenaud philrenaud deleted the 23410-ui-cannot-close-task-sidebar-if-job-was-deleted branch July 4, 2024 21:04
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: cannot close task sidebar if Job was deleted
4 participants