-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] When a job is deleted in the background, wait until redirect before cache unload #23492
[ui] When a job is deleted in the background, wait until redirect before cache unload #23492
Conversation
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable change, but it looks like it broke a related test.
Broken test is now fixed; was related to a core piece of Ember's transition-handling where a transition can happen at both a high level (the application route has one) and a low level (the redirect we're patching up here) and the former is left "floating". A try/catch block prevents the |
a4cb34a
to
16fb206
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This prevents an issue where, still on the job page, the cache-removed job would have trouble accessing properties and relationships of its now-removed Ember Data object.
Resolves #23410