cli: fix tls ca create command with -domain
#19892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
added
backport/1.6.x
schmichael
approved these changes
Feb 6, 2024
lgfa29
force-pushed
the
cli-fix-ca-create
branch
from
bdd0214 to
c89742a
Compare
The current implementation of the `nomad tls ca create` command ovierrides the value of the `-domain` flag with `"nomad"` if no additional customization is provided. This results in a certificate for the wrong domain or an error if the `-name-constraint` flag is also used. THe logic for `IsCustom()` also seemed reversed. If all custom fields are empty then the certificate is _not_ customized, so `IsCustom()` should return false.
lgfa29
force-pushed
the
cli-fix-ca-create
branch
from
c89742a to
90f33cb
Compare
schmichael
approved these changes
Feb 7, 2024
This was referenced Feb 7, 2024
|
Does this also fix the issue that when you overwrite the organization details, the validity of the CA is set to 0 days? |
|
Hi @jonashaag 👋 I'm not sure, do you happen to have an issue that describes the problem? You can also test these changes from our latest CI build (it's all the way down the page 😅): Just keep in mind that these are development builds and should be used for any production code. |
|
Thanks, I just gave it a try. It seems to be fixed in that build. With v1.7.4: |
|
Nice, thanks for testing it. So we got a two-for-one deal on this PR 😄 The fix is available on Nomad 1.7.5 and 1.6.8 that were just released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
nomad tls ca createcommand ovierrides the value of the-domainflag with"nomad"if no additional customization is provided.This results in a certificate for the wrong domain or an error if the
-name-constraintflag is also used.The logic for
IsCustom()also seemed reversed. If all custom fields are empty then the certificate is not customized, soIsCustom()should return false.Closes #19836