consul.partition fingerprint generates warning logs on CE

[tgross]

The Consul fingerprint for Nomad CE generates a warning log after 1.7.3. I added support for fingerprinting the Consul admin partition in #19485 and tested it with combinations of Nomad CE/ENT and Consul CE/ENT. Unfortunately I apparently missed that if you fingerprint Consul CE from this code, you get a valid fingerprint and working Consul, but noise in your logs.

The "extractor" for the partition returns "", false, which the implementation treats as a warning. If we returned "", true, we wouldn't get the warning but we'd get a useless fingerprint value of consul.partition = "" which we don't want either. So we need to adjust the implementation to handle empty values differently too.

Reported in #19485 (comment)

[maxless]

@tgross Is there a way to disable this message through config currently if you're not using Consul?

[tgross]

Unfortunately no. When you leave out the consul config, Nomad generates a default one. This is something we've discussed removing entirely to make it nicer to run Nomad without Consul (as we do for the vault.enabled flag), but it hasn't managed to get to the top of the priority pile. So we've got to fix the fingerprint... I'll try to get this into the next regular release.

[maxless]

Okay, thanks.

[tgross]

Will be fixed in #19923, planned for shipping in Nomad 1.7.5

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.