Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: skip allocs with replacements on job restart #19155

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Nov 23, 2023

The nomad job restart command should skip allocations that already have replacements. Restarting an allocation with a replacement is a no-op because the allocation status is terminal and the command's replacement monitor returns immediatelly.

But by not skipping them, the effective batch size is computed incorrectly.

The `nomad job restart` command should skip allocations that already
have replacements. Restarting an allocation with a replacement is a
no-op because the allocation status is terminal and the command's
replacement monitor returns immediatelly.

But by not skipping them, the effective batch size is computed
incorrectly.
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgfa29 lgfa29 merged commit d2849b8 into main Nov 23, 2023
19 checks passed
@lgfa29 lgfa29 deleted the b-cli-job-restart-skip-replaced-allocs branch November 23, 2023 19:51
@lgfa29 lgfa29 removed the backport/1.5.x backport to 1.5.x release line label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.6.x backport to 1.6.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants