bubble up the error message from go-getter

[shantanugadgil]

possible fix for #18442

EDIT:

Tested the locally built Nomad agent binary using nomad agent -dev with:

mkdir large_tar
cd large_tar/
mkdir data
for i in {1..5000} ; do echo "" > data/$i.txt; done
tar czvf data.tar.gz data/
python3 -m http.server 9000

job "tar_fail" {

  group "cache" {
    network {
      port "db" {
        to = 6379
      }
    }

    task "redis" {
      artifact {
        source      = "http://127.0.0.1:9000/data.tar.gz"
        destination = "local/some-directory"
      }

      driver = "docker"

      config {
        image          = "redis:7"
        ports          = ["db"]
        auth_soft_fail = true
      }

      identity {
        env  = true
        file = true
      }

      resources {
        cpu    = 500
        memory = 256
      }
    }
  }
}

[shantanugadgil]

@lgfa29 @jrasell @angrycub @tgross

[tgross]

@shantanugadgil this doesn't actually get what you've described in #18442 does it? This added the inner error to the artifact block but that's only going to show up in Task Events, not the alloc logs. But I think that's actually what we want.

[shantanugadgil]

@shantanugadgil this doesn't actually get what you've described in #18442 does it? This added the inner error to the artifact block but that's only going to show up in Task Events, not the alloc logs. But I think that's actually what we want.

I meant to write alloc status in the original bug report. Bubbling the error into alloc status is good enough.

[tgross]

Hi @shantanugadgil! I've left a couple more comments. Also, can you add a changelog via make cl?

[tgross]

LGTM

I've smoke tested this with a broken artifact download and get task events like the following:

Recent Events:
Time                       Type                      Description
2023-09-13T09:35:00-04:00  Not Restarting            Policy allows no restarts
2023-09-13T09:35:00-04:00  Failed Artifact Download  failed to download artifact "s3::http://192.168.1.221:9000/test/release": getter subprocess failed: exit status 1: failed to download artifact: error downloading 'http://192.168.1.221:9000/test/release?aws_access_key_id=key&aws_access_key_secret=password1': RequestError: send request failed
caused by: Get "http://192.168.1.221:9000/test?prefix=release": dial tcp 192.168.1.221:9000: connect: connection refused
2023-09-13T09:35:00-04:00  Downloading Artifacts     Client is downloading artifacts
2023-09-13T09:34:59-04:00  Task Setup                Building Task Directory
2023-09-13T09:34:59-04:00  Received                  Task received by client

[tgross]

I've got a backport PR baking in #18479 so once that's green I'll merge it and that'll get shipped in the upcoming Nomad 1.6.2